Skip to content

Commit

Permalink
[chore] Drop Go 1.7 x Gin (latest) unit test combo (#118)
Browse files Browse the repository at this point in the history
[chore] Drop Go 1.7 x Gin (latest) unit test combo
  • Loading branch information
kinbiko authored May 17, 2019
2 parents f13f7c6 + f6f9289 commit 1eb8494
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ addons:
jobs:
include:
- stage: gotest
env: GO_VERSION=1.7
script: make ci
go: "1.7"
- script: make ci
Expand Down
11 changes: 8 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,14 @@ updatedeps:
go get -v -d -u ./...

test: alldeps
#TODO: 2018-09-20 Not testing the 'errors' package as it relies on some very runtime-specific implementation details.
# The testing of 'errors' needs to be revisited
go test . ./gin ./martini ./negroni ./sessions ./headers
@#TODO: 2018-09-20 Not testing the 'errors' package as it relies on some very runtime-specific implementation details.
@# The testing of 'errors' needs to be revisited
@# Additionally skipping Gin if the Go version is 1.7, as the latest version of Gin has dropped support.
@if [ "$(GO_VERSION)" = "1.7" ]; then \
go test . ./martini ./negroni ./sessions ./headers; \
else \
go test . ./gin ./martini ./negroni ./sessions ./headers; \
fi
@go vet 2>/dev/null ; if [ $$? -eq 3 ]; then \
go get golang.org/x/tools/cmd/vet; \
fi
Expand Down

0 comments on commit 1eb8494

Please sign in to comment.