Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Drop Go 1.7 x Gin (latest) unit test combo #118

Merged
merged 1 commit into from
May 17, 2019
Merged

Conversation

kinbiko
Copy link
Contributor

@kinbiko kinbiko commented May 16, 2019

We currently pull down the latest versions of all our dependencies, including Gin, before attempting to run our tests. Gin has recently dropped their support for Go 1.7, and we therefore have to ignore the Gin tests when running CI against Go 1.7.

Additionally silence comments in Makefile

Linked issues

Related to #117 as this PR is blocked by a failing build which this aims to solve.

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

We currently pull down the latest versions of all our dependencies,
including Gin, before attempting to run our tests. Gin has recently
dropped their support for Go 1.7, and we therefore have to ignore the
Gin tests when running CI against Go 1.7.

Additionally silence comments in Makefile
@kinbiko kinbiko requested a review from bengourley May 16, 2019 14:14
Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

GO_VERSION=1.7 make test skips the gin tests on my local, and make test does not. And perhaps more importantly, the CI is green.

@kinbiko kinbiko merged commit 1eb8494 into next May 17, 2019
@kinbiko kinbiko deleted the ignore-gin-go-1-7 branch May 17, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants