Optimized bug listing items (mostly "buglist.cgi"). #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Much deploying [ https://bugzilla.mozilla.org/show_bug.cgi?id=1572075#c3 ]. Slightly refactored. "scalar" keyword here is misuse. References: https://perldoc.perl.org/functions/scalar https://perldoc.perl.org/perlop#C-style-Logical-Or https://stackoverflow.com/questions/13846676
MasterInQuestion
commented
Jan 2, 2024
| @@ -684,11 +684,17 @@ ORDER: for ($order) { | |||
| } | |||
| } | |||
|
|
|||
| if (!scalar @order_columns) { | |||
There was a problem hiding this comment.
"misuse": Exactly, just pointless.
Also merged [ https://github.com/bugzilla/bugzilla/pull/155 ]. And edition based on which. Also somewhat refactored the adjacent "if": Notations for complex data structure in Perl are poorly defined. "->" notoriously... See also: https://perldoc.perl.org/perlop#The-Arrow-Operator https://perldoc.perl.org/perlreftut#Use-Rule-2 https://stackoverflow.com/questions/24106193#24109344
lukialvaro080808
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much deploying [ https://bugzilla.mozilla.org/show_bug.cgi?id=1572075#c3 ].
Slightly refactored.
"scalar" keyword here is ~~
misuse~~ [ Exactly, just pointless. ].References:
https://perldoc.perl.org/functions/scalar
https://perldoc.perl.org/perlop#C-style-Logical-Or
https://stackoverflow.com/questions/13846676