Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized bug listing items (mostly "buglist.cgi"). #157

Open
wants to merge 3 commits into
base: 5.2
Choose a base branch
from
Open

Optimized bug listing items (mostly "buglist.cgi"). #157

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b72fe9a
"buglist.cgi": Optimized bug listing items.
MasterInQuestion Jan 1, 2024
e16929b
"Bugzilla/Constants.pm": Optimized bug listing items.
MasterInQuestion Jan 1, 2024
08aa8ff
"buglist.cgi": Set "splitheader" as default.
MasterInQuestion Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions buglist.cgi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,11 +684,17 @@ ORDER: for ($order) {
}
}

if (!scalar @order_columns) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    "misuse": Exactly, just pointless.


# DEFAULT
@order_columns = ("bug_status", "priority", "assigned_to", "bug_id");
}
# DEFAULT when "@order_columns" is empty ("undef").
if ( ! @order_columns ) {
@order_columns = ( "changeddate DESC", "reporter", "short_desc" );
};
#
# `@order_columns //=` alike is quirky:
# https://www.google.com/search?hl=en&gl=ca&num=100&filter=0&q=Perl+%22Can%27t+modify+array+dereference%22|%22Can%27t+modify+private+array%22+%22in+logical+or+assignment%22|%22in+defined+or+assignment%22
#
# `@order_columns = @order_columns || ...` won't work as intended:
# "@order_columns" in which returns the number of elements.
#

# In the HTML interface, by default, we limit the returned results,
# which speeds up quite a few searches where people are really only looking
Expand Down