feat: make wiz-dir configurable #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defgenx
force-pushed
the
feat/make-wiz-dir-configurable
branch
from
e4faec4
to
0ea085d
Compare
toote
requested changes
Jul 25, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| set -uo pipefail | |||
|
|
|||
| WIZ_DIR="$HOME/.wiz" | |||
| WIZ_DIR="${BUILDKITE_PLUGIN_WIZ_WIZ_DIR:=$HOME/.wiz}" | |||
There was a problem hiding this comment.
I don't see a reason to re-assign the variable (and may cause issues) so using the default parameter substitution instead may be preferable for consistency with the others at least:
Suggested change
| WIZ_DIR="${BUILDKITE_PLUGIN_WIZ_WIZ_DIR:=$HOME/.wiz}" | |
| WIZ_DIR="${BUILDKITE_PLUGIN_WIZ_WIZ_DIR:-$HOME/.wiz}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the plugin user to configure a specific directory for
WIZ_DIR.