Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make wiz-dir configurable #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: make wiz-dir configurable #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hooks/post-command
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

set -uo pipefail

WIZ_DIR="$HOME/.wiz"
WIZ_DIR="${BUILDKITE_PLUGIN_WIZ_WIZ_DIR:=$HOME/.wiz}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason to re-assign the variable (and may cause issues) so using the default parameter substitution instead may be preferable for consistency with the others at least:

Suggested change
WIZ_DIR="${BUILDKITE_PLUGIN_WIZ_WIZ_DIR:=$HOME/.wiz}"
WIZ_DIR="${BUILDKITE_PLUGIN_WIZ_WIZ_DIR:-$HOME/.wiz}"

SCAN_TYPE="${BUILDKITE_PLUGIN_WIZ_SCAN_TYPE:-}"
FILE_PATH="${BUILDKITE_PLUGIN_WIZ_PATH:-}"
PARAMETER_FILES="${BUILDKITE_PLUGIN_WIZ_PARAMETER_FILES:-}"
Expand Down
2 changes: 2 additions & 0 deletions plugin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ configuration:
type: string
image-address:
type: string
wiz-dir:
type: string
output-format:
type: string
enum:
Expand Down