Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add many more agent config options #391

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add many more agent config options #391

merged 1 commit into from
Oct 8, 2024

Conversation

DrJosh9000
Copy link
Contributor

What

Add a subset of agent config options to values.yaml, and more git-related options to checkout params.

Why

There are huge gaps in the configurability of the agent, that so far require:

  • building a custom agent image to bake in a custom config, or
  • complicated chains of configuration in a pipeline or values file (env var + volume with podSpecPatch + extraVolumeMounts), or
  • putting agent config in pipeline-level env vars, that outside this stack are usually prevented from having an effect

There's a need to supply many of the same config options, and also to put a k8s twist on some of them (e.g. instead of hooks-path, what about hooks-volume-source?)

Copy link
Contributor

@wolfeidau wolfeidau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one observation / question, great work!

internal/controller/config/agent_config.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@DrJosh9000 DrJosh9000 merged commit f4b48fa into main Oct 8, 2024
1 check passed
@DrJosh9000 DrJosh9000 deleted the more-params branch October 8, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants