Suppress 'ignored env' warning #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set
BUILDKITE_IGNORED_ENVto a blank var, to suppress the error message.Note that this behaviour depends on the next agent release (v3.83.0?)
Why
agent-stack-k8s circumvents the normal flow of env vars through the agent - it sets all the job vars on the checkout/command containers, when (outside of the k8s stack) the agent wouldn't do this. This never caused a warning until the agent started passing more env vars through the socket, including
BUILDKITE_IGNORED_ENV, which the agent populates, causing the warning to appear even though the vars are not actually ignored.What we should do is provide a way to set all the agent configuration that is normally set as "protected" env vars (#391), and then un-circumvent the env var shenanigans the scheduler does (future work). Until then, we can ignore the ignored-env warning.