Refactor the various agent HTTP clients #3017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
agent-http-client-cleanup
branch
2 times, most recently
from
dc2e64b
to
e6d29f7
Compare
patrobinson
approved these changes
Oct 7, 2024
| transport = newTransport(&conf) | ||
| transportCache[cacheKey] = transport | ||
| } | ||
| transportCacheMu.Unlock() |
There was a problem hiding this comment.
Is the goal by sharing the transports here to also share the connection pooling?
Once side effect is when we call CloseIdleConnections that impacts all clients using this transport, even if they have a different http client. I think that's ok?
There was a problem hiding this comment.
Yes, that's the idea, but I expect it will have very limited impact.
| }), nil | ||
|
|
||
| case strings.HasPrefix(a.conf.Destination, "s3://"): | ||
| dest = "Amazon S3" | ||
| return NewS3Uploader(a.logger, S3UploaderConfig{ | ||
| Destination: a.conf.Destination, | ||
| DebugHTTP: a.conf.DebugHTTP, |
There was a problem hiding this comment.
It seems like this option never did anything?
There was a problem hiding this comment.
Yep, set and never used.
DrJosh9000
force-pushed
the
agent-http-client-cleanup
branch
from
e6d29f7
to
0f08356
Compare
DrJosh9000
force-pushed
the
agent-http-client-cleanup
branch
from
0f08356
to
d025f04
Compare
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It'd sure be be nice to do HTTP clients consistently the same way in the agent. Then we could reuse Pat's trace work, disable HTTP/2 consistently, ...
Context
Noticed while working on artifacts, which create blank
&http.Client{}s or usehttp.DefaultClient.Changes
Do, again with functional optionscontext.Backgroundand a deprecated methodDebugHTTPfieldsNot changed:
GSUploaderandGSDownloadermake use ofgoogle.DefaultClient. These remain.Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)