Allow kpack controller to aggregate rbac rolebindings to access ProvisionedServices resources #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewmcnew
requested review from
tylerphelan,
tomkennedy513,
sambhav and
dumez-k
tomkennedy513
approved these changes
Feb 10, 2022
julian-hj
reviewed
Feb 10, 2022
There was a problem hiding this comment.
I think it would be useful to also add a sentence or two to the documentation to state that there must be a ClusterRole with the servicebinding.io/controller label. Although it is called out in the k8s docs it is listed as a "should" and is pretty easy to miss.
tylerphelan
approved these changes
Feb 10, 2022
sambhav
approved these changes
Feb 10, 2022
matthewmcnew
force-pushed
the
aggregation-servicebindings
branch
from
5a880a9 to
27b5dfc
Compare
…sionedServices resources #921
matthewmcnew
force-pushed
the
aggregation-servicebindings
branch
from
27b5dfc to
70505a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#921