Binding to a ProvisionedService object swallows errors and proceeds with no logging

[julian-hj]

While attempting to use the ProvisionedService service binding, we found that the binding was missing from our build pod, with no log messages explaining why.

Eventually we figured out that the kpack admin role lacked access to our custom type, but to do that, we had to rebuild the controller with additional trace messages injected into the code.

We found that this method returns blank object if the target object cannot be found (for any reason) or if it doesn't fulfill the ProvisionedService duck type.

It's very easy to get the binding wrong--either because the roles aren't set up, or because the type is specified incorrectly, or because some controller hasn't yet set the status on the object, so it doesn't yet conform to the duck type. So it would be much better if there were log messages in the kpack controller logs and/or a status message on the Image object to help diagnose the issue.

[matthewmcnew]

@julian-hj Does the ProvisonedService define a ClusterRole with a label matching servicebinding.io/controller=true? If so, this PR should give the kpack controller rbac access.

[matthewmcnew]

Before this issue is closed we should add better error handling here.

[julian-hj]

Hi @matthewmcnew yeah, that PR would definitely help some, but I think it would still be better to error & requeue the Image when the ProvisionedService can't be fully resolved, rather than proceeding.