Improved error handling so that binding to a ProvisionedService object no longer swallows errors #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal test coverage.
ncarlson
requested review from
tomkennedy513,
matthewmcnew and
tylerphelan
and removed request for
tomkennedy513
Codecov Report
@@ Coverage Diff @@
## main #952 +/- ##
==========================================
+ Coverage 69.75% 70.00% +0.25%
==========================================
Files 120 120
Lines 5475 5475
==========================================
+ Hits 3819 3833 +14
+ Misses 1285 1271 -14
Partials 371 371
Continue to review full report at Codecov.
|
…d changed APIVersion to fake.kpack.io.
tylerphelan
approved these changes
Apr 25, 2022
matthewmcnew
approved these changes
Apr 26, 2022
matthewmcnew
deleted the
921-binding-to-a-provisionedservice-object-swallows-errors-and-proceeds-with-no-logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed error handling on readProvisionedServiceDuckType. Added additional test coverage.