Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detector output missing group number #105

Closed
ameyer-pivotal opened this issue Mar 28, 2019 · 4 comments
Closed

Detector output missing group number #105

ameyer-pivotal opened this issue Mar 28, 2019 · 4 comments
Assignees
@djoyahoy
Milestone
0.2.0

Comments

@ameyer-pivotal
Copy link
Contributor

When running pack,

[detector] Trying group of 2...

should read

[detector] Trying group <some number> of 2...
@djoyahoy djoyahoy self-assigned this Apr 8, 2019
djoyahoy pushed a commit that referenced this issue Apr 8, 2019
Fix detect to log 'Trying group X of Y...' [#105]
075dea0 
Signed-off-by: Danny Joyce <djoyce@pivotal.io>
djoyahoy pushed a commit that referenced this issue Apr 8, 2019
Detector prints number of buildpacks in addition to groups
3391786 
[#105]

Signed-off-by: Danny Joyce <djoyce@pivotal.io>
djoyahoy added a commit that referenced this issue Apr 8, 2019
@djoyahoy
Merge pull request #112 from buildpack/fix-detector-group-logging
1218b42 
Fix detect to log 'Trying group X of Y...' [#105]
@mgibson1121
Copy link
Member

@djoyahoy Not seeing the right output based on @ameyer-pivotal's comment. Here's my detector output (running pack-0.1.0-build.94-darwin)

===> DETECTING
[detector] Trying group of 8...
[detector] ======== Results ========
[detector] Cloud Foundry OpenJDK Buildpack: pass
[detector] Cloud Foundry Build System Buildpack: pass
[detector] Cloud Foundry JVM Application Buildpack: pass
[detector] Cloud Foundry Azure Application Insights Buildpack: skip
[detector] Cloud Foundry Debug Buildpack: skip
[detector] Cloud Foundry Google Stackdriver Buildpack: skip
[detector] Cloud Foundry JMX Buildpack: skip
[detector] Cloud Foundry Procfile Buildpack: skip

@djoyahoy
Copy link
Member

djoyahoy commented Apr 10, 2019 •
edited
Loading

@mgibson1121 This would be a lifecycle change so you'd need to select a builder with the right lifecycle binaries. Let me see if I can get you a builder with the latest lifecycle binaries.

@mgibson1121
Copy link
Member

After pairing with @djoyahoy, accepting this story

@ekcasey
Copy link
Member

ekcasey commented Apr 25, 2019

fixed on master

@ekcasey ekcasey closed this as completed Apr 25, 2019
@ekcasey ekcasey added the v0.2.0 label Apr 25, 2019
@jromero jromero added this to the 0.2.0 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djoyahoy djoyahoy

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
5 participants
@jromero @ekcasey @djoyahoy @mgibson1121 @ameyer-pivotal