Fix detect to log 'Trying group X of Y...' [buildpack/lifecycle#105] #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Joyce <djoyce@pivotal.io>
sclevine
requested changes
Apr 8, 2019
detector.go
Outdated
| @@ -199,6 +198,7 @@ type BuildpackOrder []BuildpackGroup | |||
|
|
|||
| func (bo BuildpackOrder) Detect(c *DetectConfig) (plan []byte, group *BuildpackGroup) { | |||
| for i := range bo { | |||
| c.Out.Printf("Trying group %d of %d...", i + 1, len(bo)) | |||
There was a problem hiding this comment.
Now we've lost the buildpack count, which was the original purpose of the line.
If we feel we need more info here, how about:
Trying group 3 out of 5 with 8 buildpacks...
c.Out.Printf("Trying group %d out of %d with %d buildpacks...", i+1, len(bo), len(bo[i].Buildpacks))There was a problem hiding this comment.
Ah, ok. I thought the intent was to simply log which group we were currently trying.
[#105] Signed-off-by: Danny Joyce <djoyce@pivotal.io>
sclevine
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Joyce djoyce@pivotal.io