Generate lifecycle sbom #944
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
- Coverage 66.18% 66.06% -0.11%
==========================================
Files 84 84
Lines 5813 5872 +59
==========================================
+ Hits 3847 3879 +32
- Misses 1579 1600 +21
- Partials 387 393 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Amazing work @omocquais-p! It's really exciting to see this come to fruition. I added a couple comments, but overall this is looking to be in good shape.
omocquais-p
force-pushed
the
generate-lifecycle-sbom
branch
from
19d78aa to
6f2f3fb
Compare
omocquais-p
force-pushed
the
generate-lifecycle-sbom
branch
2 times, most recently
from
66813dc to
079c8fb
Compare
|
|
||
| e.Logger.Infof("Copying " + component + " SBOM (" + destSbomFilename + ")") | ||
| } else { | ||
| e.Logger.Warn(sbomFilename + " is missing") |
There was a problem hiding this comment.
Discussed offline - we can probably do the check earlier and not create the directory if there are no SBOM files.
Signed-off-by: Olivier Mocquais <omocquais@vmware.com>
omocquais-p
force-pushed
the
generate-lifecycle-sbom
branch
from
853e92c to
141e1c9
Compare
There was a problem hiding this comment.
@omocquais-p great work, and thank you for the contribution!
Note: IMO Codecov is being too picky here, as the constants are already implicitly tested elsewhere. I don't think we need to add any more tests.
#958