Add launcher SBOM input #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
jjbustamante
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
I loved how simply is adding a new flag after the refactoring! Great Job @natalieparellano
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
- Coverage 64.54% 64.44% -0.10%
==========================================
Files 86 86
Lines 6175 6171 -4
==========================================
- Hits 3985 3976 -9
- Misses 1813 1820 +7
+ Partials 377 375 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Sigh... again I think Codecov is being too picky (the newly exported constants are being tested implicitly elsewhere). @jabrown85 do you have an opinion? |
|
I'm fine with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow on to #944, this PR introduces a
-launcher-sbomflag to the exporter & creator so that users who supply their own launcher can supply an SBOM for that launcher.Related spec PR: https://github.com/buildpacks/spec/pull/332/files?diff=split&w=1