go 1.20 #1740
Merged
go 1.20 #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/chore
|
I feel like there was some concern with updating golang version too often. Is that right @natalieparellano or @AidanDelaney ? |
|
cc also @dfreilich I'd be okay with moving to 1.20 at this point as the minor already has 3 patches. |
|
Go v1.19 was released in pack https://github.com/buildpacks/pack/releases/tag/v0.29.0, so I'm fine with it in this release :) |
|
We also need to update the |
|
also need to fix some uses of |
Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
All of our calls to Seed were with current time, so they were intended to produce different pseudo-random sequences on each run. We were never calling Seed with a fixed value to create reproducible sequences of pseudo-random numbers. Therefore it should be safe to just delete the calls. per the docs (https://pkg.go.dev/math/rand@master#Seed): > If Seed is not called, the generator is seeded randomly at program startup. > Prior to Go 1.20, the generator was seeded like Seed(1) at program startup. To force the old behavior, call Seed(1) at program startup. Alternately, set GODEBUG=randautoseed=0 in the environment before making any calls to functions in this package. > Deprecated: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator. Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
github-actions
bot
added
the
type/enhancement
|
thanks @joe-kimmel-vmw. i'm merging this into #1758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
upgrades golang version
Documentation
Related
Resolves #___