Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.20 #1740

Merged
merged 4 commits into from
May 12, 2023
Merged

go 1.20 #1740

merged 4 commits into from
May 12, 2023

Commits on Apr 26, 2023

  1. go 1.20

    Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
    joe-kimmel-vmw committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    c3fcf9d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Configuration menu
    Copy the full SHA
    6cdc9d2 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. updates makefile and github actions to 1.20 also

    Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
    joe-kimmel-vmw committed May 10, 2023
    Configuration menu
    Copy the full SHA
    deeb700 View commit details
    Browse the repository at this point in the history
  2. removes all calls to rand.Seed

    All of our calls to Seed were with current time, so they
    were intended to produce different pseudo-random sequences on each run.
    We were never calling Seed with a fixed value to create reproducible
    sequences of pseudo-random numbers.  Therefore it should be safe to just
    delete the calls.
    
    per the docs (https://pkg.go.dev/math/rand@master#Seed):
    
    > If Seed is not called, the generator is seeded randomly at program startup.
    
    > Prior to Go 1.20, the generator was seeded like Seed(1) at program startup. To force the old behavior, call Seed(1) at program startup. Alternately, set GODEBUG=randautoseed=0 in the environment before making any calls to functions in this package.
    
    > Deprecated: As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator.
    
    Signed-off-by: Joe Kimmel <jkimmel@vmware.com>
    joe-kimmel-vmw committed May 10, 2023
    Configuration menu
    Copy the full SHA
    4060795 View commit details
    Browse the repository at this point in the history