Add buildpack API to io.buildpacks.build.metadata label #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For newer platform API (0.10 and above) we need to know the buildpack API to know if the process args are overridable or not (when there is more than one element in the command, the process is definitely from a newer buildpack, but if there is only one element in the command, the args could be overridable or not overridable depending on the buildpack API). Having this information will allow platforms such as pack to display process information to end users. The lifecycle is already adding processes[0].buildpackID to the label, this updates the spec to reflect the current implementation. Signed-off-by: Natalie Arellano <narellano@vmware.com>
sambhav
approved these changes
Nov 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been an oversight in implementing overridable process args - the launcher has access to buildpack API in
<layers>/config/metadata.tomlbut it is not printed in the label, hence platforms do not have all the required information to display processes correctly (or at least, to allow end users to distinguish between overridable and non-overridable args).For newer platform API (0.10 and above) we need to know the buildpack API to know if the process args are overridable or not (when there is more than one element in the command, the process is definitely from a newer buildpack, but if there is only one element in the command, the args could be overridable or not overridable depending on the buildpack API).
Having this information will allow platforms such as pack to display process information to end users.
The lifecycle is already adding processes[0].buildpackID to the label, this updates the spec to reflect the current implementation.