Finalize platform/0.11 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
For newer platform API (0.10 and above) we need to know the buildpack API to know if the process args are overridable or not (when there is more than one element in the command, the process is definitely from a newer buildpack, but if there is only one element in the command, the args could be overridable or not overridable depending on the buildpack API). Having this information will allow platforms such as pack to display process information to end users. The lifecycle is already adding processes[0].buildpackID to the label, this updates the spec to reflect the current implementation. Signed-off-by: Natalie Arellano <narellano@vmware.com>
(This was added for the restorer but inadvertently omitted from the extender) Also lints table borders and properly alphabetizes restorer inputs Signed-off-by: Natalie Arellano <narellano@vmware.com>
[RFC 0112] Platform API changes for lifecycle/launcher SBOM
Clarify: `<kaniko-dir>` is an input to the extender
Add buildpack API to io.buildpacks.build.metadata label
RFC #109 defines a directory allowing operators to set environment variables for detect and build phases. Specify how the buildpack phases should implement the behavior. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Handles buildpacks/rfcs#262 Signed-off-by: Jesse Brown <jabrown85@gmail.com> Signed-off-by: Jesse Brown <jabrown85@gmail.com>
Describe how CNB_BUILD_CONFIG_DIR variables MUST be provided in the lifecycle execution environment and the suffixes that are allowed. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Revert changes to buildpack.md so that platform.md can be merged into appropriate branches. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Sambhav Kothari <sambhavs.email@gmail.com>
Define CNB_BUILD_CONFIG_DIR behavior
Add `<previous-image>` to rebaser
jkutner
approved these changes
Feb 8, 2023
hone
reviewed
Feb 8, 2023
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes:
Platform API 0.11
Additions
launcherare included in the exported image within<layers>/sbom/launch; SBOM files for thelifecycleare saved to<layers>/sbom/build; theexporteraccepts a-launcher-sbomflag to allow platforms to provide SBOM files for a customlauncher([RFC 0112] Platform API changes for lifecycle/launcher SBOM #332, RFC 0112)/cnb/config/envdirectory (Define CNB_BUILD_CONFIG_DIR behavior #345, RFC 0109)rebaseraccepts a-previous-imageflag to allow rebasing by digest reference (Add<previous-image>to rebaser #346, RFC 0115)Nonfunctional Changes
io.buildpacks.build.metadatalabel to accurately reflect existing lifecycle behavior (Add buildpack API to io.buildpacks.build.metadata label #328)<kaniko-dir>is an input to theextender(Clarify:<kaniko-dir>is an input to the extender #329)