Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change logic of buildtest parser by converting to class #1612

Merged
merged 29 commits into from
Sep 8, 2023

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

add a method to return subparsers that can be used by buildtest commands to automatically get list of buildtest commands
… list of valid words to autocomplete for 'buildtest' program
@shahzebsiddiqui shahzebsiddiqui changed the title improve logic of buildtest parser by converting to class change logic of buildtest parser by converting to class Aug 31, 2023
add dictionary self.subparsers that is used to automatically build all the parsers.
Make use of self.subparsers to automatically pick parser when creating the arguments for each parser object.
…ples that are used to build the command option.

This was done for 'buildtest style', 'buildtest unittests', 'buildtest path', 'buildtest history'
create method for building argument parser for buildtest buildspec find
remove short option '-t' for '--theme' since there was a name conflict with
buildtest buildspec find --tags that has short option '-t'
…ash. we use url.join to build

the path as pose to using string manipulation
…reate argument groups.

The options that require mutual exclusion were added manually
… creating a single variable to store

all configuration options
…', 'clean', and 'show' command by using a list

of dict
…method

fix issue with hidden parsers showing up with help message. Now with --help-all it will only show
parser otherwise its hidden
fix issue where buildtest report command was shown twice in 'buildtest --help'
rename several variables
…t commands that can be used by buildtest commands variable to show

all valid commands it wont show the aliases by default
…mands with aliases

by default it will show only main commands
…p' option we added a case statment

to group all commands into one case statement

add tab completion for 'buildtest commands' that includes --with-aliases option
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 97.60% and project coverage change: -0.13% ⚠️

Comparison is base (a46c20e) 78.16% compared to head (bf8456f) 78.02%.
Report is 41 commits behind head on devel.

❗ Current head bf8456f differs from pull request most recent head 574b20c. Consider uploading reports for the commit 574b20c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1612      +/-   ##
==========================================
- Coverage   78.16%   78.02%   -0.13%     
==========================================
  Files          57       57              
  Lines        6656     6607      -49     
==========================================
- Hits         5202     5155      -47     
+ Misses       1454     1452       -2     
Files Changed Coverage Δ
buildtest/cli/config.py 86.87% <ø> (ø)
buildtest/cli/__init__.py 98.27% <97.47%> (+0.02%) ⬆️
buildtest/cli/cdash.py 88.61% <100.00%> (ø)
buildtest/cli/commands.py 100.00% <100.00%> (ø)
buildtest/cli/show.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahzebsiddiqui shahzebsiddiqui merged commit 2f1c2a2 into devel Sep 8, 2023
30 of 34 checks passed
@shahzebsiddiqui shahzebsiddiqui deleted the BuildTestParser branch September 8, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant