Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change logic of buildtest parser by converting to class #1612

Merged
merged 29 commits into from
Sep 8, 2023

Commits on Aug 30, 2023

  1. add class BuildTestParser and move logic for get_parser into this class

    add a method to return subparsers that can be used by buildtest commands to automatically get list of buildtest commands
    shahzebsiddiqui committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    9002044 View commit details
    Browse the repository at this point in the history
  2. update bash completion script to use 'buildtest commands' to retrieve…

    … list of valid words to autocomplete for 'buildtest' program
    shahzebsiddiqui committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5b117ee View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Configuration menu
    Copy the full SHA
    54bb724 View commit details
    Browse the repository at this point in the history
  2. add method main_options that handles creating buildtest options

    add dictionary self.subparsers that is used to automatically build all the parsers.
    Make use of self.subparsers to automatically pick parser when creating the arguments for each parser object.
    shahzebsiddiqui committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    20666ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    68badb2 View commit details
    Browse the repository at this point in the history
  4. rewrite logic of several methods to capture arguments as a list of tu…

    …ples that are used to build the command option.
    
    This was done for 'buildtest style', 'buildtest unittests', 'buildtest path', 'buildtest history'
    shahzebsiddiqui committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    7b13b34 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. delete content where we manually added arguments and subparsers

    create method for building argument parser for buildtest buildspec find
    remove short option '-t' for '--theme' since there was a name conflict with
    buildtest buildspec find --tags that has short option '-t'
    shahzebsiddiqui committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    df56c77 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7bb68f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ab97b8d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bb44209 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3bf38b5 View commit details
    Browse the repository at this point in the history
  6. fix bug in joining url when viewing cdash link. There was an extra sl…

    …ash. we use url.join to build
    
    the path as pose to using string manipulation
    shahzebsiddiqui committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    c459957 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. rewrite buildtest report argparse menu using multiple variables and c…

    …reate argument groups.
    
    The options that require mutual exclusion were added manually
    shahzebsiddiqui committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    1163c3b View commit details
    Browse the repository at this point in the history
  2. rewrite code for 'buildtest config' menu for building the argparse by…

    … creating a single variable to store
    
    all configuration options
    shahzebsiddiqui committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    d727cdf View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. save changes

    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fa14a62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f7c6823 View commit details
    Browse the repository at this point in the history
  3. rewrite method misc_menu that buidls parser for commands 'cd', 'stats…

    …', 'clean', and 'show' command by using a list
    
    of dict
    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1d951aa View commit details
    Browse the repository at this point in the history
  4. add mutual exclusion for options --json, --yaml for buildtest config …

    …compilers list
    
    rewrite section help_all
    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    0517776 View commit details
    Browse the repository at this point in the history
  5. remove method _build_parser and move implementation to main __init__ …

    …method
    
    fix issue with hidden parsers showing up with help message. Now with --help-all it will only show
    parser otherwise its hidden
    fix issue where buildtest report command was shown twice in 'buildtest --help'
    rename several variables
    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    806a5e9 View commit details
    Browse the repository at this point in the history
  6. add variable self.buildtest_subcommands to store list of all buildtes…

    …t commands that can be used by buildtest commands variable to show
    
    all valid commands it wont show the aliases by default
    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    fbb31fd View commit details
    Browse the repository at this point in the history
  7. add option --with-aliases for 'buildtest commands' to show all subcom…

    …mands with aliases
    
    by default it will show only main commands
    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8551945 View commit details
    Browse the repository at this point in the history
  8. fix issues with tab completion for some commands that only had '--hel…

    …p' option we added a case statment
    
    to group all commands into one case statement
    
    add tab completion for 'buildtest commands' that includes --with-aliases option
    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    6c13832 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5238897 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    cf71232 View commit details
    Browse the repository at this point in the history
  11. add method to retrieve all buildtest options. This will be helpful in…

    … auto-completing the buildtest options
    
    instead of manually creating them
    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    c707ab5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    702a2a7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    bf8456f View commit details
    Browse the repository at this point in the history
  14. applying black

    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    574b20c View commit details
    Browse the repository at this point in the history
  15. add quotation mark around $cur in bash completion to avoid word split…

    …ting and globbing reported by codefactor
    shahzebsiddiqui committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bd06335 View commit details
    Browse the repository at this point in the history