Refactor buildtest codebase #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to handle logic for each command option.
…gic for specific commands. Add setup() method to handle logic for start of buildtest environment
…' and 'buildtest config edit-file'. The positional argument wasnt working
…buildspec_in_editor and validate_buildspec
…ing if test name is in cache and method for printing buildspec content
for more information, see https://pre-commit.ci
remove 'compiler' from types list for schema table since 'compiler' is no longer supported
…ting and creating tables
for more information, see https://pre-commit.ci
… ('buildtest buildspec maintainers --breakdown')
for more information, see https://pre-commit.ci
…ldspec find invalid) by using methods like create_table, print_table for printing. Add --pager and --row-count option to the command menu since implementation was present but option was not. fix bug in regression test where method name was not correct.
… were not neccessary.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… maintainers' command. add option --row-count for 'buildtest buildspec find invalid' to show count of invalid tests add implementation for these options Add bash completion support for new options
fix bug in regression test for viewing executors
remove unused variables in method handle_executors_command
…ethod name create_table used for generating tables. Remove option --theme from 'buildtest buildspec summary' since its not implemented in codebase
… helper method create_history_table used for printing the table history
The Report class will now pass values as **kwargs and there is a method set_report_parameters that will assign instance variables passed on **kwargs. Make use of nested for loops and combining if statements together to help reduce lines of codes where possible
…must match the actual arguments for buildtest report command
… message for some options
fix issue where --count=0 was not showing up the output correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.