Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor buildtest codebase #1763

Merged
merged 30 commits into from
Apr 30, 2024
Merged

Refactor buildtest codebase #1763

merged 30 commits into from
Apr 30, 2024

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    1b60d40 View commit details
    Browse the repository at this point in the history
  2. refactor codebase for 'buildtest config' by creating smaller methods …

    …to handle logic for each command option.
    shahzebsiddiqui committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7f862ed View commit details
    Browse the repository at this point in the history
  3. refactor main method of buildtest by creating methods for handling lo…

    …gic for specific commands.
    
    Add setup() method to handle logic for start of buildtest environment
    shahzebsiddiqui committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    67a60f7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    87c02ec View commit details
    Browse the repository at this point in the history
  5. fix issue with command parser for showing 'buildtest config edit-test…

    …' and 'buildtest config edit-file'. The positional argument wasnt working
    shahzebsiddiqui committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    3a70810 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f8243a5 View commit details
    Browse the repository at this point in the history
  7. refactor method edit_buildspec_file to make use of methods like open_…

    …buildspec_in_editor and validate_buildspec
    shahzebsiddiqui committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    fb3d734 View commit details
    Browse the repository at this point in the history
  8. refactor codebase for 'show_buildspec' by adding methods for determin…

    …ing if test name
    
    is in cache and method for printing buildspec content
    shahzebsiddiqui committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    7c6149f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6a8418c View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    8a6278a View commit details
    Browse the repository at this point in the history
  2. change print statement in exception class

    remove 'compiler' from types list for schema table since 'compiler' is no longer supported
    shahzebsiddiqui committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ce738a9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    93b47ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ce0551 View commit details
    Browse the repository at this point in the history
  5. refactor codebase for printing breakdown of buildspecs by maintainers…

    … ('buildtest buildspec maintainers --breakdown')
    shahzebsiddiqui committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    4084c33 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c1b0fa4 View commit details
    Browse the repository at this point in the history
  7. refactor implementation for finding invalid buildspecs (buildtest bui…

    …ldspec find invalid) by using methods
    
    like create_table, print_table for printing.
    
    Add --pager and --row-count option to the command menu since implementation was present but option was not.
    fix bug in regression test where method name was not correct.
    shahzebsiddiqui committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    18c038b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    18654fc View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3f07208 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    5c4ffb5 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e6802ce View commit details
    Browse the repository at this point in the history
  12. add options --pager, --no-header and --count for 'buildtest buildspec…

    … maintainers' command.
    
    add option --row-count for 'buildtest buildspec find invalid' to show count of invalid tests
    add implementation for these options
    
    Add bash completion support for new options
    shahzebsiddiqui committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    0e1e38b View commit details
    Browse the repository at this point in the history
  13. add __init__.py files in subdirectories for some tests

    fix bug in regression test for viewing executors
    shahzebsiddiqui committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    c086135 View commit details
    Browse the repository at this point in the history
  14. fix issues with regression test with incorrect method variable name.

    remove unused variables in method handle_executors_command
    shahzebsiddiqui committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    09ec730 View commit details
    Browse the repository at this point in the history
  15. refactor implementation for buildtest buildspec summary by creating m…

    …ethod name create_table used
    
    for generating tables.
    Remove option --theme from 'buildtest buildspec summary' since its not implemented in codebase
    shahzebsiddiqui committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    173655f View commit details
    Browse the repository at this point in the history
  16. refactor implementation for 'buildtest history' command by creating a…

    … helper method create_history_table used for printing the table history
    shahzebsiddiqui committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    6c4db37 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. refactor Report class and all of its helper methods.

    The Report class will now pass values as **kwargs and there is a method set_report_parameters
    that will assign instance variables passed on **kwargs.
    
    Make use of nested for loops and combining if statements together to help reduce lines of codes where possible
    shahzebsiddiqui committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    61caf4b View commit details
    Browse the repository at this point in the history
  2. rename argument call when calling Report class since kwargs argument …

    …must match the actual arguments for buildtest report command
    shahzebsiddiqui committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2b49e56 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ca24589 View commit details
    Browse the repository at this point in the history
  4. refactor inspect.py

    shahzebsiddiqui committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0cb8d98 View commit details
    Browse the repository at this point in the history
  5. add regression test for testing --count

    fix issue where --count=0 was not showing up the output correctly
    shahzebsiddiqui committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9b47768 View commit details
    Browse the repository at this point in the history