Improvements to Builder Class and improvement to container support and enable strict mode for tests #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapping for calling each check function instead of having many if statements. Add support for --strict option in 'buildtest build' that will be used for toggling 'set -eo pipefail'. This feature is supported with profiles and using rerun feature (--rerun). Add example buildspec used for showing how --strict option will work
…n generated profile settings
…' that uses an extension type other than .yml. Added regression test to get coverage for this feature
…ywhere. This allows us to invoke full path to container runtime after calling this method. This also works with container executors.
…s was a spelling error
…dd os.path.exists
… and handling of command object in method handle_run_result
shahzebsiddiqui
deleted the
improvements_to_builder_class_and_support_for_strict_mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.