Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Builder Class and improvement to container support and enable strict mode for tests #1777

Merged
merged 13 commits into from
May 15, 2024
Merged

Improvements to Builder Class and improvement to container support and enable strict mode for tests #1777

merged 13 commits into from
May 15, 2024

Commits on May 14, 2024

  1. refactor codebase for check_test_state by making use of a dictionary 

    mapping for calling each check function instead of having many if statements.
Add support for --strict option in 'buildtest build' that will be used for toggling
'set -eo pipefail'.

This feature is supported with profiles and using rerun feature (--rerun).

Add example buildspec used for showing how --strict option will work
    @shahzebsiddiqui
    shahzebsiddiqui committed May 14, 2024
    Configuration menu
    Copy the full SHA
    2edd4a1 View commit details
    Browse the repository at this point in the history

  2. add documentation on strict mode using example buildspec

    @shahzebsiddiqui
    shahzebsiddiqui committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f8bd638 View commit details
    Browse the repository at this point in the history

  3. add '--strict' for bash completion

    @shahzebsiddiqui
    shahzebsiddiqui committed May 14, 2024
    Configuration menu
    Copy the full SHA
    7ecd245 View commit details
    Browse the repository at this point in the history

  4. add regression test for strict mode and update marker names for cli

    @shahzebsiddiqui
    shahzebsiddiqui committed May 14, 2024
    Configuration menu
    Copy the full SHA
    36da1f1 View commit details
    Browse the repository at this point in the history

  5. update profile generation test with 'strict' to ensure its captured i… 

    …n generated profile settings
    @shahzebsiddiqui
    shahzebsiddiqui committed May 14, 2024
    Configuration menu
    Copy the full SHA
    419cd06 View commit details
    Browse the repository at this point in the history

  6. we raise an exception when using 'buildtest build --write-config-file… 

    …' that uses an extension type other than .yml.

Added regression test to get coverage for this feature
    @shahzebsiddiqui
    shahzebsiddiqui committed May 14, 2024
    Configuration menu
    Copy the full SHA
    82bce2c View commit details
    Browse the repository at this point in the history

  7. add a method name check_container_runtime which can be called from an… 

    …ywhere. This allows

us to invoke full path to container runtime after calling this method. This also works with
container executors.
    @shahzebsiddiqui
    shahzebsiddiqui committed May 14, 2024
    Configuration menu
    Copy the full SHA
    291a8fc View commit details
    Browse the repository at this point in the history

  8. remove reference to 'cobalt' in json schema which is not used in buil… 

    …dtest anymore
    @shahzebsiddiqui
    shahzebsiddiqui committed May 14, 2024
    Configuration menu
    Copy the full SHA
    70af067 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. fix bug in regression test when calling lambda function

    @shahzebsiddiqui
    shahzebsiddiqui committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6a8b725 View commit details
    Browse the repository at this point in the history

  2. address build error in documentation with unknown directive type. Thi… 

    …s was a spelling error
    @shahzebsiddiqui
    shahzebsiddiqui committed May 15, 2024
    Configuration menu
    Copy the full SHA
    5150b0a View commit details
    Browse the repository at this point in the history

  3. fix issue where broken symbolic links were not working we needed to a… 

    …dd os.path.exists
    @shahzebsiddiqui
    shahzebsiddiqui committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8a83141 View commit details
    Browse the repository at this point in the history

  4. refactor logic for run method by decompossing it into several methods

    @shahzebsiddiqui
    shahzebsiddiqui committed May 15, 2024
    Configuration menu
    Copy the full SHA
    a90e762 View commit details
    Browse the repository at this point in the history

  5. fix some bugs reported in regression test related to how running test… 

    … and handling of command object in method handle_run_result
    @shahzebsiddiqui
    shahzebsiddiqui committed May 15, 2024
    Configuration menu
    Copy the full SHA
    00c63ac View commit details
    Browse the repository at this point in the history