Refine Integration #710
Draft
Refine Integration #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspth
commented
Dec 1, 2023
...in-super_scaffolding/app/models/scaffolding/completely_concrete/tangible_thing/assignment.rb
Outdated
Show resolved
Hide resolved
2 tasks
ssteffen
reviewed
Dec 6, 2023
|
|
||
| condition(:date_field_value, :date), | ||
| condition(:date_and_time_field_value, :datetime), | ||
| condition(:created_at, :datetime), |
There was a problem hiding this comment.
One thing I would recommend is we add in the clause manipulations for created_at and updated_at generators. The IS_SET and IS_NOT_SET clauses serve no purpose for these fields since they are always present so the scaffolding should probably automatically apply
.without_clauses([DateWithTimeCondition::CLAUSE_SET, DateWithTimeCondition::CLAUSE_NOT_SET]) for simplicity
There was a problem hiding this comment.
Nope, looks like that was fixed in clickfunnels2/refine-rails#157, but I happened to be running an older version of Refine (thought I'd updated ugh).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrating refine-rails into Bullet Train.
Starter Repo PR: bullet-train-co/bullet_train#1233