Show user-configured list of clauses in inline filters #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QUE-185 Useless negative clauses should be hidden in the Inline Filter
Description It causes an issue with these negative filters not working. It was hidden for the old filter in: https://github.com/clickfunnels2/admin/pull/21567 Video: https://www.loom.com/share/2c5e89fa59fb4d2a8f32610a1c0a093f Acceptance Criteria <How will we know that it's working properly? List out details as to what everyone should expect.> Testing Notes |
ssteffen
approved these changes
Nov 30, 2023
existentialmutt
deleted the
rafe-que-185-useless-negative-clauses-should-be-hidden-in-the-inline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug with inline filters. They were previously showing all possible clauses for a new criterion. This PR fixes that behavior to only show the clauses configured for that condition.
This will fix QUE-185