Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise test framework #78

Closed
1 of 2 tasks
OGKevin opened this issue Apr 3, 2018 · 0 comments
Closed
1 of 2 tasks

Optimise test framework #78

OGKevin opened this issue Apr 3, 2018 · 0 comments
Assignees
@OGKevin
Labels
enhancement
Milestone
1.0.0

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Apr 3, 2018

Steps to reproduce:

  1. Try and execute tests

What should happen:

  1. It should be easy and fast

What happens:

  1. It is hard to set up and can take up to 10 mins to complete.

Traceback

SDK version and environment

  • Tested on 0.12.4
  • Sandbox
  • Production

Response id

  • Response id:

Extra info:

Reference: bunq/sdk_php#120
@OGKevin OGKevin added this to the 0.13.5 milestone Apr 3, 2018
@OGKevin OGKevin self-assigned this Apr 3, 2018
@OGKevin OGKevin changed the title Optimize test framework Optimise test framework Apr 3, 2018
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Added idea folder to git ignore. (#78)
812c235
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Fixed broken isSessionActive method. (#78)
451deed
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Made it possible to get env url via enum. (#78)
dd8ae32
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Made some constants public. (#78)
268e2e6
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Refactored base test class. (#78)
e826eb9
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Refactored tests to use the new base class. (#78)
8467210
@OGKevin OGKevin mentioned this issue May 12, 2018
Merged
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Removed unused imports. (#78)
c12a285
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Added missing assertions. (#78)
58adb6c
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Reverted the removal of expected exception. (#78)
b9a1b66
OGKevin added a commit that referenced this issue May 12, 2018
@OGKevin
Added comment why method is empty. (#78)
b075dec
OGKevin added a commit that referenced this issue May 16, 2018
@OGKevin
Made session context class public. (#78)
38b52f0
OGKevin added a commit that referenced this issue May 16, 2018
@OGKevin
Fixed failing test. (#78)
255d46d
@OGKevin OGKevin mentioned this issue May 16, 2018
Merged
OGKevin added a commit that referenced this issue May 28, 2018
@OGKevin
Added comment for why we ask for spending money. (#78)
d0f9ed0
OGKevin added a commit that referenced this issue May 28, 2018
@OGKevin
Refresh contex after requesting money. (#78)
86acab5
OGKevin added a commit that referenced this issue May 28, 2018
@OGKevin
Merge pull request #85 from bunq/optimise_test_framework_bunq/sdk_jav…
1deed2e 
…a#78

Optimise test framework (#78)
@OGKevin OGKevin closed this as completed May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@OGKevin