Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Optimise test framework for CI. #120

Closed
1 of 2 tasks
OGKevin opened this issue Apr 2, 2018 · 0 comments · Fixed by #121 or #123
Closed
1 of 2 tasks

Fix/Optimise test framework for CI. #120

OGKevin opened this issue Apr 2, 2018 · 0 comments · Fixed by #121 or #123
Assignees
@OGKevin
Labels
enhancement
Milestone
1.0.0

Comments

@OGKevin
Copy link
Contributor

OGKevin commented Apr 2, 2018

Steps to reproduce:

  1. Try and execute tests

What should happen:

  1. It should be easy and fast

What happens:

  1. It is hard to set up and can take up to 10 mins to complete.

Traceback

SDK version and environment

  • Tested on 0.12.4
  • Sandbox
  • Production

Response id

  • Response id:

Extra info:
@OGKevin OGKevin added this to the 0.13.5 milestone Apr 2, 2018
@OGKevin OGKevin self-assigned this Apr 2, 2018
OGKevin added a commit that referenced this issue Apr 2, 2018
@OGKevin
Removed old test files. (#120)
28998fe
OGKevin added a commit that referenced this issue Apr 2, 2018
@OGKevin
Inital commit for test optimization. (#120)
5b74a81
OGKevin added a commit that referenced this issue Apr 2, 2018
@OGKevin
Removed magic values. (#120)
075348e
OGKevin added a commit that referenced this issue Apr 2, 2018
@OGKevin
Upgraded php unit and installed paratest. (#120)
b480501
OGKevin added a commit that referenced this issue Apr 2, 2018
@OGKevin
Updated dependencies. (#120)
fe14305
OGKevin added a commit that referenced this issue Apr 2, 2018
@OGKevin
Enusre all tests have assertions. (#120)
a19a2e8
OGKevin added a commit that referenced this issue Apr 2, 2018
@OGKevin
Refactored according to base class. (#120)
c938b62
@OGKevin OGKevin mentioned this issue Apr 2, 2018
Merged
1 task
OGKevin added a commit that referenced this issue Apr 2, 2018
@OGKevin
Removed unneede new line and imports. (#120)
cef556b
This was referenced Apr 3, 2018
Closed
Closed
Closed
OGKevin added a commit that referenced this issue Apr 3, 2018
@OGKevin
Renamed some methods and vars. (#120)
46c568c
OGKevin added a commit that referenced this issue Apr 3, 2018
@OGKevin
Removed magic value. (#120)
4a0ee1a
OGKevin added a commit that referenced this issue Apr 3, 2018
@OGKevin
Removed trailing wihte space and unused import. (#120)
4385389
OGKevin added a commit that referenced this issue Apr 3, 2018
@OGKevin
Merge pull request #121 from bunq/optimise_test_framework_bunq/sdk_ph…
de3ba20 
…p#120

Optimise test framework #120
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Removed field in test. (#120)
35ed11a
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Added assertions to tests missing it. (#120)
88b5149
@OGKevin OGKevin mentioned this issue Apr 5, 2018
Merged
1 task
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Ensure test account has enough money on it. (#120)
7e1cddd
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Removed field in test. (#120)
960a884
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Added assertions to tests missing it. (#120)
36529a3
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Fixed request description. (#120)
14845a8
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Minor refactor. (#120)
59b2aff
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Removed unneeded docs and imports. (#120)
6c164f8
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Minor refactor. (#120)
8f959d2
OGKevin added a commit that referenced this issue Apr 5, 2018
@OGKevin
Merge pull request #123 from bunq/optimise_test_framework_auto_topup_…
a188cf4 
…#120

Optimise test framework auto topup #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OGKevin OGKevin

Labels
enhancement
Projects
None yet
Milestone
1.0.0
1 participant
@OGKevin