Remove accepted_kwargs decorator #1229
Conversation
Remove the function decorator accepted_kwargs. We can simply put all the args on the method signature. The function filter_dict_values is useless too now, we can set the params with some None values that does not break the API calls. This: - simplifies the method signature - allows rich editors to find and display the right method signature and not just `wrapper(*args, **kwargs)`. - allows us to better type arguments - allows us to set default value like any other method using `param=Defaultvalue` - simplifies the code in general closes #1228
|
This sounds great to me. Those function decorators were certainly a lot. As you say, were they for Python 2? This is a great change to me ♥ I added a test, because I wasn't fully sure how python 3 dealt with kwarguments used as arguments. I thought we may as well leave it in. |
thanks for the test ! 🤩 I did not think about it when removing code but that's a great addition. yes arguments can be passed in the right order or named but in the order you want. sure we'll leave it in, if we change the order of the parameters in the methods |
|
sounds good! ❤ |
Remove the function decorator accepted_kwargs.
We can simply put all the args on the method signature.
The function filter_dict_values is useless too now, we can set
the params with some None values that does not break the API calls.
This:
and not just
wrapper(*args, **kwargs).param=Defaultvaluecloses #1228