Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accepted_kwargs decorator #1229

Merged
merged 2 commits into from
Jun 18, 2023
Merged

Remove accepted_kwargs decorator #1229

merged 2 commits into from
Jun 18, 2023

Commits on Jun 18, 2023

  1. Remove accepted_kwargs decorator 

    Remove the function decorator accepted_kwargs.
We can simply put all the args on the method signature.
The function filter_dict_values is useless too now, we can set
the params with some None values that does not break the API calls.

This:
- simplifies the method signature
- allows rich editors to find and display the right method signature
  and not just `wrapper(*args, **kwargs)`.
- allows us to better type arguments
- allows us to set default value like any other method using `param=Defaultvalue`
- simplifies the code in general

closes #1228
    @lavigne958
    lavigne958 committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    6551efe View commit details
    Browse the repository at this point in the history

  2. add test_get_values_with_args_or_kwargs

    @alifeee
    alifeee committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    5f22248 View commit details
    Browse the repository at this point in the history