-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add delete-to-start/end-of-line #445
Comments
Similar to my comment here regarding the alt+backspace behaviour, removing the custom delete key handler allows meta+delete to function. Perhaps we can find a solution that leverages the default browser behaviour and mobiledoc-kit's mutation observer rather than trying to re-implement OS behaviour? |
@kevinansfield I'm actually looking at being able to operate without the keypress events as part of a solution for #589. We use key events for a few reasons:
So that is to say I'm not so sure we should simply remove the delete handler and call it a day. We would need to ensure that our own test suite still passes and all our known browsers continue to work properly. |
refs bustle#445 - add `Position.atStartOfLine` method that takes an existing position from which to find the start of it's line - add `line` unit for use in `editor.performDelete` - update delete key event handler to pass `line` unit when <kbd>Meta+Backspace</kbd> is pressed
On Mac, pressing meta+delete deletes from the cursor position to the start of the line. We would like to have this work properly in mobiledoc-kit as well.
Need to:
Position#move
to handle a"line"
unitsee #403
The text was updated successfully, but these errors were encountered: