[SPIKE] Fix typing on Android #641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatthewhat
force-pushed
the
android-bug-spike
branch
from
9785eb6
to
70c7bc6
Compare
|
Updated branch to the latest mobiledoc-kit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a proper fix for #589, but rather a hacky workaround for anyone that really needs some kind of Android support. It does however work on my Pixel and in the emulator without breaking existing use cases. I'll keep this branch alive until a better fix is implemented.
Screen recording of this branch on an actual device
After spending a bit of time reading code I'm still not familiar enough with Mobiledoc internals to attempt a proper fix.. @mixonic I wonder if your attempts to operate without keypress (1, 2) were sucessfull? That approach could probably fix the spellcheck issue (#621) as well by eliminating rerenders?