Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak our CircleCI setup to get it "just so" #2342

Open
blackshadowshade opened this issue Apr 7, 2018 · 7 comments
Open

Tweak our CircleCI setup to get it "just so" #2342

blackshadowshade opened this issue Apr 7, 2018 · 7 comments

Comments

@blackshadowshade
Copy link
Contributor

So, this is the issue where we put our wishlist of tweaks and changes to the CircleCI setup.

@blackshadowshade blackshadowshade added this to the Technical debt milestone Apr 7, 2018
@blackshadowshade
Copy link
Contributor Author

blackshadowshade commented Apr 7, 2018

On a PHPCS failure (e.g., https://circleci.com/gh/blackshadowshade/buttonmen/19), the email from CircleCI suggests "For more detailed failure reports, use JUnit XML formatting." and has a link to https://circleci.com/docs/1.0/test-metadata/

If we were able to specify this format for the PHPCS output, then I'm guessing that the failure message would show the contents of the XML file, meaning that I don't need to go digging through Artifacts to find the errors.

@blackshadowshade
Copy link
Contributor Author

For #2338, we'll need to be able to tweak the CircleCI setup to enable newer versions of Ubuntu, PHP, and potentially other components as well.

@cgolubi1
Copy link
Contributor

cgolubi1 commented Apr 7, 2018

One thing you should keep an eye out for is that we have a CircleCI 2.0 config. They seem to be mid-migration from 1.0 to 2.0, and i didn't see any reason not to pick the newer one, which seemed like it had a more flexible config language. But as a rule that means if you find a 1.0 doc for how to do something, you probably need to look for a 2.0 doc to do the same thing, because they totally rewrote the config language.

@blackshadowshade
Copy link
Contributor Author

It would be useful to be able to follow someone else's builds in my control panel.

@blackshadowshade
Copy link
Contributor Author

blackshadowshade commented Apr 24, 2018

Our QUnit runs seem to be rather inconsistent, sometimes failing because QUnit cannot seem to find all of the source during one run, and then passing on the next run when it does manage to find all the source.

As an example, the following runs all ran on the same source code, and all failed for different reasons:
https://circleci.com/gh/blackshadowshade/buttonmen/34
https://circleci.com/gh/blackshadowshade/buttonmen/38
https://circleci.com/gh/blackshadowshade/buttonmen/39

@cgolubi1
Copy link
Contributor

cgolubi1 commented May 5, 2018

So... i'm really suspicious: the files QUnit needs are being rsynced immediately before the QUnit tests run, and as you say, the failure mode looks consistent with the files not being there yet. Obviously, rsync is exiting successfully. But i wonder if the files are being copied to some kind of eventually consistent data store. In which case the fix would be to verify that the files exist before succeeding the step. Let me experiment with that.

@blackshadowshade
Copy link
Contributor Author

I've rebased #2311, #2314, and #2355. The first two have explicit UI changes, while the last does not. #2314 has never passed testing before, the others have (but only intermittently). We'll see whether these all pass now.

@blackshadowshade blackshadowshade mentioned this issue Sep 8, 2018
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants