Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CircleCI step which tries to verify that the dummy API files have landed before running QUnit #2364

Merged

Conversation

cgolubi1
Copy link
Contributor

  • Partially addresses Tweak our CircleCI setup to get it "just so" #2342
  • I can't prove this works or that i've diagnosed the problem correctly --- my test CircleCI run passed on the first try, and we know we're getting spurious QUnit failures pretty often in CircleCI (i'd say at least 1/5 of the time?), so if we merge this and don't see more spurious failures, or if we merge this and ever see it need to sleep once before continuing, we should feel very confident in it. And if we merge this and do see another spurious failure, we can go back to the drawing board.

@cgolubi1 cgolubi1 requested a review from blackshadowshade May 13, 2018 15:48
@blackshadowshade
Copy link
Contributor

I'm happy to try this. I'll rebase my pull requests (when I have time) and then I'll rerun them all, including the one I haven't been able to get to pass yet. We'll see if this makes a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants