Removed "Any button" option when filters are selected #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This failed some of the QUnit tests. |
blackshadowshade
force-pushed
the
1796_hide_any_button
branch
from
a77c2e2 to
31db1e7
Compare
|
I've updated and expanded the QUnit tests so we're actually testing something meaningful. I've also rebased. http://jenkins.buttonweavers.com:8080/job/buttonmen-blackshadowshade/1445/ |
blackshadowshade
force-pushed
the
1796_hide_any_button
branch
from
31db1e7 to
fb1485c
Compare
blackshadowshade
force-pushed
the
1796_hide_any_button
branch
from
fb1485c to
88a4749
Compare
|
Eww, sorry this has been sitting for so long. Let me put up a dev site so we can take a look at it. |
|
Irilyth, can you sync up: ephemeral = 54.163.26.189 |
|
Anyway, this looks fine to me. Leaving the site up for a day or two for other opinions. |
Done! |
|
No other opinions forthcame. Merging. |
This was referenced Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1796.
http://jenkins.buttonweavers.com:8080/job/buttonmen-blackshadowshade/1444/ (if it passes)