Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS scroll bounce fix - skip event if scrollTop < 0 #566

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

toddtarsi
Copy link
Contributor

@toddtarsi toddtarsi commented Feb 8, 2017

If we're at a scrollTop above 0, just avoid triggering the scroll event entirely, or maybe I should pass the event through.
This is a McDonalds fix, feel free to critique this as needed. Thanks!
Resolves #532

@bvaughn
Copy link
Owner

bvaughn commented Feb 8, 2017

Hey @toddtarsi,

This fix seems reasonably safe- but I'd really like to be able to reproduce the problem and verify that this change fixes it before merging.

Any chance I could get a more detailed description of how to reproduce the behavior? Or a video demo?

@bvaughn
Copy link
Owner

bvaughn commented Feb 8, 2017

PS. Thanks for the PR 😁

@toddtarsi
Copy link
Contributor Author

toddtarsi commented Feb 8, 2017

Absolutely, I am filming local iOS device repro using the demo server. :)
Will have shortly.

@toddtarsi
Copy link
Contributor Author

Okay, I had some issues with the demo server, so I ended up using my team's application to demonstrate the fix:

PFA using the standard virtualized list (technically infinite loader, but irrelevant here when everything is loaded):

issue

PFA using the virtualized list after this fix:

resolution

@bvaughn
Copy link
Owner

bvaughn commented Feb 14, 2017

Thanks! This is great. Very helpful.

@bvaughn bvaughn merged commit 2fbc110 into bvaughn:master Feb 14, 2017
@maxsalven
Copy link

Hi @bvaughn @toddtarsi,

This fix solved issues when scrolling upwards, however I still get visual flickers when over scrolling downwards past the bottom of a list.

Let me know if you are unable to reproduce, I can try capture a video somehow if so. Many thanks.

toddtarsi added a commit to toddtarsi/react-virtualized that referenced this pull request Mar 16, 2017
Untested Resolution for follow up by @maxsalven on bvaughn#566
@toddtarsi
Copy link
Contributor Author

@maxsalven -

Nah. That issue makes sense. In the same way this avoids recalculating the render when scrolling above the beginning, I figured at some point we'd need to resolve this issue when scrolling past the end as well. If you could help me out by demoing if the fix (#616) resolves your issue, I would be appreciative.

@bvaughn - Sorry I didn't include this in the original fix, but I wrote a small patch for it here: #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visual bug: flickering when over scrolling on ios
3 participants