-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
visual bug: flickering when over scrolling on ios #532
Comments
If you'd be willing to take a look at this and submit a PR- I'd be happy to review it. Realistically I won't have time to debug anything like this for a good while. |
I'm testing on ios - corodova w/ CDVWKWebViewEngine turned on. The overscroll flickers after releasing the over scroll, then my infinite list stops responding to scroll completely. |
Wonder if this is related to #453 |
I was using a fixed positioned div to hold the infinite scroller. When I switch that to an absolutely positioned div I still see the flicker and momentary loss of the ability to scroll but then it recovers. |
I do have the same flicker on an iOS 10.2 device. I noticed that if I have 10 000 items in the list, the flicker is pretty light but if I put 25 000 items in the list, the flicker is more obvious and annoying! Anyone has an idea what it could come from? Maybe some items are re-rendered when overscrolling? |
If we're at a scrollTop above 0, just avoid triggering the scroll event entirely, or maybe I should pass the event through. This is a McDonalds fix, feel free to critique this as needed. Thanks! Resolves bvaughn#532
@rlebosse - You are exactly right. Initially, I thought this was caused by an invalid scroll event. I've written a very basic fix here: #566 Basically, all it does is hook into the onScroll handler and prevent it from doing anything if we see the scroll is below 0, indicating we're playing with our scroll bounce. No flickers, but I also may have missed considering any other issues this may cause. Thanks for the awesome repo! |
@toddtarsi 's fix will go out with the upcoming RV9 release. |
using ios 9.2 device, go to https://bvaughn.github.io/react-virtualized/
pull down on the List so the first row goes lower (ie. this is an "over scroll" which can be done on ios)
i will see intermittent flicker/jumping of the list rendering for brief moment at the top of the overscroll. it should not render at the top of an overscroll.
this bug is not always apparent, if you do not see it first time, try overscrolling again or overscrolling faster.
i have tried adjusting overscan setting up and down, but I have not noticed any visible improvement.
The text was updated successfully, but these errors were encountered: