-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the mobile browser, it will shake when scrolling to the top or bottom. #244
Comments
This looks like Safari elastic scrolling and not something this library in particular is doing. |
I am observing similar behavior on Safari iOS (not seeing in Chrome iOS). FWIW, found a commit from react-virtualized that seems like it was related to this problem: https://github.com/bvaughn/react-virtualized/pull/616/files |
Want to try that out in react-window @blenoski ? |
@bvaughn I also have to update my comment 2 back, I was able to reproduce on Chrome iOS. Attaching a screen capture from iPhone7 for reference: |
Cool, thanks! 😁 |
Update: It does require knowing the current height of the innerContainer element plus the height of the last row which I imagine will be the tricky part. Also, assuming similar issues would exist for horizontal scrolling but have not yet been able to reproduce the flickering there. Anyhow, going to pull down the repo and dig into the code a little to see if I can figure this out :) |
I just noticed the same. This issue is basically this old react-virtualized issue. |
Worth noting that the linked RV commit was reverted in bvaughn/react-virtualized#616 so the long-standing RV solution to this is just to prevent scroll offsets less than 0. I think I'm comfortable making that change to RW as well, although I'll need to make sure it doesn't break RTL. Also may be worth mentioning this comment:
|
Fix elastic bounce issues and RTL issues
Bug fix released in 1.8.2 - https://github.com/bvaughn/react-window/blob/master/CHANGELOG.md#182 |
Such as the title, list will shake when scrolling to the top or bottom, but react-virtualized is not happened.
You can view the video below.
video url
The text was updated successfully, but these errors were encountered: