Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 244] List flickers on iOS during rubber band overscrolling #250

Closed
wants to merge 3 commits into from

Conversation

blenoski
Copy link

Added logic to determine whether or not we have overscrolled
vertical scrolling boundaries of list.

Updated list vertical scrolling handler to skip rerenders
if we have overscrolled.

blenoski added 2 commits May 23, 2019 10:22
Added logic to determine whether or not we have overscrolled
vertical scrolling boundaries of container.

Updated list vertical scrolling handler to skip rerenders
if we have overscrolled.
@TrySound
Copy link
Contributor

/cc @istarkov

@EyMaddis
Copy link

EyMaddis commented May 27, 2019

The same applies for horizontal scrolling, but is ignored in this PR.
This might also break with RTL support as in that case the offset "should" be negative.

@bvaughn
Copy link
Owner

bvaughn commented May 27, 2019

Thanks for this PR!

I'm incorporating the ideas from this along with RTL PRs #162 and #215 into PR #251.

@bvaughn bvaughn closed this May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants