Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing of devel Go version fails #131

Closed
martin-sucha opened this issue Feb 7, 2023 · 1 comment · Fixed by #132
Closed

Parsing of devel Go version fails #131

martin-sucha opened this issue Feb 7, 2023 · 1 comment · Fixed by #132

Comments

@martin-sucha
Copy link
Contributor

bingo version output:

v0.7

go version output:

go version devel go1.21-02d8ebda83 Mon Feb 6 22:13:07 2023 +0000 linux/amd64

What happened:

When running a bingo command with a development version of Go, Bingo commands fail.
Even simple bingo version prints the following error:

Error: version command failed: parse go version: unexpected go version format

What you expected to happen:

Bingo parses the version.

How to reproduce it (as minimally and precisely as possible):

  1. Compile a development version of Go (e.g. checkout the Go sources, cd src, ./make.bash
  2. Make the dev Go version reachable from PATH
  3. Run bingo version

Anything else we need to know:

There is an additional devel token in the go version output, so parseGoVersion needs to be adjusted.
martin-sucha added a commit to kiwicom/bingo that referenced this issue Feb 7, 2023
@martin-sucha
Relax parsing of go version
1997cf7 
Development versions of Go have an additional token before the version:

go version devel go1.21-02d8ebda83 Mon Feb 6 22:13:07 2023 +0000
linux/amd64

Use the regular expression on the whole output of go version instead of
just on the third token.

Fixes bwplotka#131
@martin-sucha martin-sucha mentioned this issue Feb 7, 2023
Merged
@bwplotka
Copy link
Owner

Yup, bug to fix, thanks for proposing fix, commented.

martin-sucha added a commit to kiwicom/bingo that referenced this issue Feb 13, 2023
@martin-sucha
Relax parsing of go version
7415370 
Development versions of Go have an additional token before the version:

go version devel go1.21-02d8ebda83 Mon Feb 6 22:13:07 2023 +0000
linux/amd64

Use the regular expression on the whole output of go version instead of
just on the third token.

Fixes bwplotka#131
bwplotka pushed a commit that referenced this issue Feb 13, 2023
@martin-sucha
Relax parsing of go version (#132)
2d71c63 
Development versions of Go have an additional token before the version:

go version devel go1.21-02d8ebda83 Mon Feb 6 22:13:07 2023 +0000
linux/amd64

Use the regular expression on the whole output of go version instead of
just on the third token.

Fixes #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Relax parsing of go version kiwicom/bingo
2 participants
@martin-sucha @bwplotka