Relax parsing of go version #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also it seems the regex should not include |
|
Hey, thanks! Let's make sure this works on dev version of Go, why not. Do you mind adding test and ensuring existing tests don't fail? |
Development versions of Go have an additional token before the version: go version devel go1.21-02d8ebda83 Mon Feb 6 22:13:07 2023 +0000 linux/amd64 Use the regular expression on the whole output of go version instead of just on the third token. Fixes bwplotka#131
martin-sucha
force-pushed
the
ms/devel-go-version
branch
from
1997cf7 to
7415370
Compare
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development versions of Go have an additional token before the version:
Use the regular expression on the whole output of go version instead of just on the third token.
Fixes #131