Enable promises behind a feature #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Simplified the test runner since we can now rely on proises :D |
|
I left an offline note to @jeffcharles, but I'll add here too for visibility: before landing this I'd like for us to ensure that unhandled rejected promises are behaving correctly, a preliminary test on my end shows that the current behaviour doesn't throw, which is wrong afaik. So we might have to fix that. |
|
This is probably also a reminder that we should run test262 |
|
Yeah, going a bit further, wpt has a suite for promises https://web-platform-tests.org/writing-tests/testharness-api.html#promise-rejection, so perhaps we should enable that to avoid missing any edge cases. |
|
Discussed offline, we're going to put this behind a default off feature for now |
jeffcharles
changed the title
saulecabrera
approved these changes
Feb 14, 2023
Closed
saulecabrera
added a commit
to saulecabrera/javy
that referenced
this pull request
Jul 8, 2024
This commit refactors the event loop handling code, mainly by extracting the common pieces into a reusable function. Additionally, this commit ensures that the result of `Promise.finish` is corectly handled, which fixes execution of code with top level awaits. Finally, this commit also ensures that we test the `experimental_event_loop` in CI for the CLI and core crates (follow-up to bytecodealliance#238)
3 tasks
saulecabrera
added a commit
that referenced
this pull request
Jul 8, 2024
* Tidy up event loop handling code This commit refactors the event loop handling code, mainly by extracting the common pieces into a reusable function. Additionally, this commit ensures that the result of `Promise.finish` is corectly handled, which fixes execution of code with top level awaits. Finally, this commit also ensures that we test the `experimental_event_loop` in CI for the CLI and core crates (follow-up to #238) * Clippy fixes * Assert fuel conditionally When the `experimental_event_loop` feature is enabled, a bit more work is done when executing JS code, therefore there's more fuel usage reported in some tests. * Create `cli-features.yml` * Add right naming * Fix `runs-on` key * Typo and fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature is off by default. It can be enabled by running
make cli CORE_FEATURES=experimental_event_loopand tests can be run by invokingmake test-cli CORE_FEATURES=experimental_event_loop CLI_FEATURES=experimental_event_loop.