Tidy up event loop handling code #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the event loop handling code, mainly by extracting the common pieces into a reusable function. Additionally, this commit ensures that the result of `Promise.finish` is corectly handled, which fixes execution of code with top level awaits. Finally, this commit also ensures that we test the `experimental_event_loop` in CI for the CLI and core crates (follow-up to bytecodealliance#238)
5 tasks
When the `experimental_event_loop` feature is enabled, a bit more work is done when executing JS code, therefore there's more fuel usage reported in some tests.
|
There's something strange about this failure, it's not failing locally. Let me look into it. I'll report back once it's solved. |
jeffcharles
reviewed
Jul 8, 2024
jeffcharles
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the event loop handling code, mainly by extracting the common pieces into a reusable function.
Additionally, this commit ensures that the result of
Promise.finishis corectly handled, which fixes execution of code with top level awaits.Finally, this commit also ensures that we test the
experimental_event_loopin CI for the CLI and core crates (follow-up to #238)Checklist
javy-cliandjavy-coredo not require updating CHANGELOG files.