bump windows-sys dependency to 0.59.0 #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you change this to allow either 0.52 or 0.59, as the errno crate does? That way it won't introduce duplicate window-sys dependencies for existing users that are using 0.52. And yes, main is good. I'll backport it to 0.38 after it's landed. |
The code is compatible with version 0.52.0 and version 0.59.0. Additionally, bump errno to 0.3.10 to get this requirement on errno as well.
vthib
force-pushed
the
update-windows-sys-0.59
branch
from
3db6f5c to
863f86a
Compare
|
Yes good idea, I updated the requirements |
|
Thanks! |
sunfishcode
pushed a commit
that referenced
this pull request
Dec 8, 2024
The code is compatible with version 0.52.0 and version 0.59.0. Additionally, bump errno to 0.3.10 to get this requirement on errno as well.
sunfishcode
pushed a commit
that referenced
this pull request
Dec 8, 2024
The code is compatible with version 0.52.0 and version 0.59.0. Additionally, bump errno to 0.3.10 to get this requirement on errno as well.
|
This is now released in rustix 0.38.42. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The windows-sys crate has been bumped to 0.59.0 4 months ago. In my projcets, most of the crates using it has been updated but rustix, hence this PR to align it.
I followed the same changes as were done in #935 , that is bumping the errno version at the same time to make it use this new windows-sys version as well.
I didn't know whether to push this to main or 0.38, i figured main is probably the right one and a backport could be done, but tell me if you need me to target another branch.
Thanks!