Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-sys 0.52 #935

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Update windows-sys 0.52 #935

merged 2 commits into from
Nov 28, 2023

Conversation

kennykerr
Copy link
Contributor

This is the first update to the windows-sys crate in 8 months. https://github.com/microsoft/windows-rs/releases/tag/0.52.0

@sunfishcode
Copy link
Member

Thanks for the PR! The CI failure is in a pretty subtle test; I can take on the task of debugging that.

@sunfishcode
Copy link
Member

Rustix also depends on the errno crate which depends on window-sys. I've submitted lambda-fairy/rust-errno#91 to update it to windows-sys 0.52. It appears windows-sys 0.52 will require bumping errno's MSRV from 1.48 to 1.56.

@sunfishcode
Copy link
Member

The errno crate depending on windows-sys 0.48 appears to be the cause of the CI failure as well, so both issues here will be resolved when errno updates.

@sunfishcode
Copy link
Member

errno 0.3.8 is now released, updated to windows-sys 0.52. I've now added a patch here to update errno to 0.3.8.

@sunfishcode sunfishcode merged commit dbd3521 into bytecodealliance:main Nov 28, 2023
44 checks passed
@sunfishcode
Copy link
Member

This is now released in 0.38.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants