Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to windows-sys 0.52. #91

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Update to windows-sys 0.52. #91

merged 3 commits into from
Nov 28, 2023

Conversation

sunfishcode
Copy link
Collaborator

No description provided.

It appears windows-sys 0.52 has an MSRV of 1.56. Update the errno crate
to 1.56 as well.
@sunfishcode
Copy link
Collaborator Author

@lambda-fairy The Rust ecosystem is starting to migrate to windows-sys 0.52, which has an MSRV of 1.56. 1.56 is still a pretty conservative MSRV to update to at this time; for example, current Debian stable has Rust 1.63, however I wanted to raise this in case anyone has any concerns.

@lambda-fairy
Copy link
Owner

@sunfishcode SGTM, thanks!

In the past I have set MSRV informally, by looking at the MSRV of dependent packages, and raising to the community on each bump (like you've done here). Up to you whether you want to keep doing that or adopt a more explicit policy.

@sunfishcode sunfishcode merged commit fbe2e15 into main Nov 28, 2023
11 checks passed
@sunfishcode sunfishcode deleted the sunfishcode/update-windows branch November 28, 2023 01:48
@sunfishcode
Copy link
Collaborator Author

This is now released in errno 0.3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants