Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libc 0.2.144 #667

Merged
merged 1 commit into from May 8, 2023
Merged

Update to libc 0.2.144 #667

merged 1 commit into from May 8, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented May 8, 2023

What does this PR try to resolve?

cargo cannot build successfully on LoongArch:

error[E0425]: cannot find value `FICLONE` in module `c`
   --> /home/hev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustix-0.37.15/src/backend/libc/io/syscalls.rs:356:16
    |
356 |             c::FICLONE as _,
    |                ^^^^^^^ not found in `c`

This is caused by some constants are missing in libc and fixed after libc 0.2.143 release.

It has the definition of `FICLONE` for LoongArch.
@heiher
Copy link
Contributor Author

heiher commented May 8, 2023

@sunfishcode, I'm not sure where to start upgrading. It seems like rustix doesn't lock libc. @weihanglo suggested that I upgrade rustix first.

@weihanglo @sunfishcode I deeply apologize for the inconvenience caused during the early bringup of LoongArch. I truly appreciate your assistance as I am in great need of your help. I am sincerely grateful.

@sunfishcode sunfishcode merged commit 707742b into bytecodealliance:main May 8, 2023
@sunfishcode
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants