Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_like: Add missing constants for loongarch64 #3237

Merged
merged 1 commit into from May 6, 2023
Merged

linux_like: Add missing constants for loongarch64 #3237

merged 1 commit into from May 6, 2023

Conversation

heiher
Copy link
Contributor

@heiher heiher commented May 6, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented May 6, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor
Copy link
Member

Thanks! @bors r+

@bors
Copy link
Contributor

bors commented May 6, 2023

📌 Commit 1d10516 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 6, 2023

⌛ Testing commit 1d10516 with merge 461807b...

@bors
Copy link
Contributor

bors commented May 6, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 461807b to master...

@bors bors merged commit 461807b into rust-lang:master May 6, 2023
bors added a commit to rust-lang/cargo that referenced this pull request May 10, 2023
Update libc to 0.2.144

### What does this PR try to resolve?

cargo cannot build successfully on LoongArch:

```
error[E0425]: cannot find value `FICLONE` in module `c`
   --> /home/hev/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rustix-0.37.15/src/backend/libc/io/syscalls.rs:356:16
    |
356 |             c::FICLONE as _,
    |                ^^^^^^^ not found in `c`
```

This is caused by some constants are missing in libc and [fixed](rust-lang/libc#3237) after `libc 0.2.143` release.

libc changelog: https://github.com/rust-lang/libc/releases/tag/0.2.143

### How should we test and review this PR?

```bash
cargo build && cargo test
```

### Additional information

None
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2023
ci: Add support for dist-loongarch64-linux

We are preparing to promote loongarch64-unknown-linux-gnu to Tier 2, and one of the tasks is to add CI support. We are currently in the process of upgrading the dependencies for the build tools, and before this is completed, we would like to request comments. Thanks

#### Progress

- [x] Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998)
- [x] Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005)
- [x] bootstrap: Update linux-raw-sys to 0.3.2 (rust-lang#110516)
- [x] Update linux-raw-sys to 0.3.4 (rust-lang#110518)
- [x] Update cargo (rust-lang#110834)
- [x] linux_like: Add missing constants for loongarch64 (rust-lang/libc#3237)
- [x] Release 0.2.143 (rust-lang/libc#3236)
- [x] Update libc to 0.2.144 (rust-lang/cargo#12098)
- [x] Update cargo (rust-lang#111456)

Tier 2 with host tools MCP: rust-lang/compiler-team#518
saethlin pushed a commit to saethlin/miri that referenced this pull request May 26, 2023
ci: Add support for dist-loongarch64-linux

We are preparing to promote loongarch64-unknown-linux-gnu to Tier 2, and one of the tasks is to add CI support. We are currently in the process of upgrading the dependencies for the build tools, and before this is completed, we would like to request comments. Thanks

#### Progress

- [x] Update linux-raw-sys to 0.3.2 (rust-lang/cargo#11998)
- [x] Update openssl-src to 111.25.3+1.1.1t (rust-lang/cargo#12005)
- [x] bootstrap: Update linux-raw-sys to 0.3.2 (rust-lang/rust#110516)
- [x] Update linux-raw-sys to 0.3.4 (rust-lang/rust#110518)
- [x] Update cargo (rust-lang/rust#110834)
- [x] linux_like: Add missing constants for loongarch64 (rust-lang/libc#3237)
- [x] Release 0.2.143 (rust-lang/libc#3236)
- [x] Update libc to 0.2.144 (rust-lang/cargo#12098)
- [x] Update cargo (rust-lang/rust#111456)

Tier 2 with host tools MCP: rust-lang/compiler-team#518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants